D7173: packaging: stage files and dynamically generate WiX installer
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Sat Feb 1 04:38:51 UTC 2020
mharbison72 added a comment.
> This change also means that Inno and WiX are now using very similar code for managing the install layout. This means that on disk both packages are nearly identical. The differences in install layout are as follows:
> ...
I diffed the WiX and Inno installs side by side, and there are a few more differences right before the 5.3 release. I don't think there's anything critical, but just in case there could be an issue:
- Inno installs `backports.configparser`, `certifi`, `dulwich`, `keyring`, `urllib3`, and `win32ctypes` in library.zip.
- Inno installs additional *.pyc files in `wsgiref`.
- ConfigParser.pyc is 24K in WiX, 1.5K in Inno. Probably related to the backport package being present in Inno.
- WiX installs a `mercurial.rc`, corresponding to `contrib/win32/mercurial.ini`; Inno does not.
Presumably `dulwich` and `keyring` were thrown in previously to support 3rd party extensions. Should we do that with WiX? Before the release? What about the other discrepancies?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7173/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7173
To: indygreg, #hg-reviewers, durin42
Cc: mharbison72, durin42, mercurial-devel
More information about the Mercurial-devel
mailing list