D7972: recover: don't verify by default

valentin.gatienbaron (Valentin Gatien-Baron) phabricator at mercurial-scm.org
Tue Feb 11 14:49:33 UTC 2020


valentin.gatienbaron added a comment.


  > I _think_ it's just paranoia. As long as the bundle wasn't woefully corrupt, it shouldn't be a problem. I _think_ if we set some of the [server]-section bundle validation options (which should be cheap enough) we could ditch this completely safely.
  > As it stands, I'm fine with this patch if someone else has the confidence to push it.
  
  How does the validity of an input bundle affect recover? I would have thought it's only the validity of the journal that matters, and that's created entirely based on local data (file lengths or contents before writes).
  
  Now I suppose the journal itself may well be truncated or not written at all when running out of disk space or other error situations where the OS does the writes out of order.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7972/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7972

To: valentin.gatienbaron, #hg-reviewers, marmoute, durin42
Cc: durin42, marmoute, pulkit, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list