D7797: rust-nodemap: pure Rust example

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Fri Feb 14 11:55:04 UTC 2020


kevincox added inline comments.
kevincox accepted this revision.

INLINE COMMENTS

> Alphare wrote in index.rs:76
> I'm not sure of the point of doing so with an mmap. We have to trust what the mmap is giving us.

In general an assertion is better than a comment because it expresses the things that you are assuming in code. I get that "it should always be" which is why I didn't suggest an `assert` but I think it is still worth codifying the assumption with a `debug_assert`.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7797/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7797

To: gracinet, #hg-reviewers, marmoute, kevincox
Cc: Alphare, marmoute, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list