D7797: rust-nodemap: pure Rust example

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Tue Feb 18 14:47:59 UTC 2020


kevincox added inline comments.

INLINE COMMENTS

> Alphare wrote in index.rs:76
> I am not sure exactly what the `debug_assert` should be? Do you want to check that the `len` is a multiple of the `align_of::<IndexEntry>`?

Yes, that seems reasonable. It shows what data you are ignoring and will alert us if we manage to hit that case in tests.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7797/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7797

To: gracinet, #hg-reviewers, marmoute, kevincox
Cc: Alphare, marmoute, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list