D7796: rust-nodemap: input/output primitives

[kevincox (Kevin Cox)]

kevincox added inline comments.
kevincox accepted this revision.

INLINE COMMENTS

> nodemap.rs:191
>      fn new() -> Self {
> -        Block([-1; 16])
> +        Block([255u8; BLOCK_SIZE])
>      }

A comment why 255 is a good number would be nice.

> nodemap.rs:334
> +            // Assert that `Block` hasn't been changed and has no padding
> +            let _: [u8; 4 * mem::size_of::<Block>()] =
> +                std::mem::transmute([Block::new(); 4]);

This should be `4 * BLOCK_SIZE` to match the code below.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7796/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7796

To: gracinet, #hg-reviewers, kevincox, durin42
Cc: yuja, Alphare, marmoute, durin42, kevincox, mercurial-devel