[PATCH 1 of 2] discovery: weaken claim about returned common heads if ancestorsof are given
Manuel Jacob
me at manueljacob.de
Fri Jul 17 04:16:29 UTC 2020
On 2020-07-17 05:15, Pierre-Yves David wrote:
> This looks correct to me. Thanks of lot to Manuel for making this
> clarification work.
>
> You should consider using mercurial.util.nouideprecwarn to catch (and
> have extension catch) user of the old attribute.
In the current patch, I forward the new name to the old name without
changing the users. However, I think that changing the name at all the
users is a good idea because then it will become more obvious in the
code if there is a bug. We’ll need to review all places using the
attribute (and possibly fix some). Using "ancestorsof" at all the users
will make the fix more obvious in the patch.
I could either:
1) send a follow-up patch doing the mass-rename and adding the warning
(this means the already sent patch stays less noisy), or
2) send a new patch combining the docstring change and the mass-rename.
> On 7/16/20 2:50 PM, Yuya Nishihara wrote:
>> On Wed, 15 Jul 2020 13:56:17 +0200, Manuel Jacob wrote:
>>> # HG changeset patch
>>> # User Manuel Jacob <me at manueljacob.de>
>>> # Date 1594799471 -7200
>>> # Wed Jul 15 09:51:11 2020 +0200
>>> # Node ID b7d3118b1fe0d41e45f630c4dd2422f56f753d81
>>> # Parent 6a5dcd75484259095abca2c5b3f7ab12421a94ad
>>> # EXP-Topic discovery
>>> discovery: weaken claim about returned common heads if ancestorsof
>>> are given
>>
>> Looks good to me, but I don't have expertise about discovery logic.
>>
>> Pierre-Yves, can you review these patches?
>> _______________________________________________
>> Mercurial-devel mailing list
>> Mercurial-devel at mercurial-scm.org
>> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>>
More information about the Mercurial-devel
mailing list