D8200: pull: add `--confirm` flag to confirm before writing changes

Tue Mar 3 18:26:27 UTC 2020

durin42 added inline comments.

INLINE COMMENTS

> exchange.py:1807
>      with wlock, repo.lock(), pullop.trmanager:
> +        if repo.ui.configbool(b"pull", b"confirm"):
> +            add_confirm_callback(repo, pullop)

I think this should probably respect HGPLAIN. Thoughts?

(Note that doing so will require some reworking, because you probably want `HGPLAIN=1 hg pull --confirm` to confirm, and it wouldn't if you just respect HGPLAIN on this line.)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8200/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8200

To: pulkit, #hg-reviewers
Cc: durin42, mercurial-devel