D8215: rust-status: move to recursive traversal to prepare for parallel traversal

Thu Mar 5 08:43:02 UTC 2020

Alphare added a comment.
Alphare added a subscriber: marmoute.

  In D8215#122325 <https://phab.mercurial-scm.org/D8215#122325>, @durin42 wrote:

  > 1. I get test-check-rust-format.t errors

  Indeed. It appears that none of the machines I use to run the entire test suite (so... not my laptop) have rustfmt installed, which skips this test. I have updated the series to fix this issue, and will install rustfmt where needed.

  > 2. I don't seem to be having any luck running the tests. It looks like the rust module policy doesn't cause the right things to get installed? In particular, `HGWITHRUSTEXT=cpython HGMODULEPOLICY=rust+c make clean tests` flunks `test-remotefilelog-datapack.py` because it can't import parsers.so? And it looks like `test-dirstate-race.t` is just broken by this series?

  I will look into this, this is bad.

  > 3. The re2-missing fallback message breaks tests for users that want rust things, but lack re2. This isn't going to work, I'm afraid.

  @marmoute suggested I do something in `debuginstall` to check for `re2` on the Rust side instead, I think it's a good idea.

  > The series is so big it's not practical for me to figure out which revision(s) I should be commenting on, so hopefully that's actionable feedback...

  It is, thanks!

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8215/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8215

To: Alphare, #hg-reviewers
Cc: marmoute, durin42, mercurial-devel