D6734: git: skeleton of a new extension to _directly_ operate on git repos

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Mar 6 21:55:42 UTC 2020


martinvonz added a comment.


  I think there are many py3 errors in this patch, but I'll queue it (mostly) as is for now. I'll send a patch to fix some of those py3 issues as a follow-up.

INLINE COMMENTS

> durin42 wrote in gitlog.py:150
> I'm seeing shortest() actually returning short hashes (4-bytes, like I've got configured) so I'm not sure what's broken.
> 
> I added a test, which passes under python3.

That test case fails on py3 for me. I'll wrap the `id + b'%'` in `pycompat.sysstr()` in flight to make the test case pass.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6734/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6734

To: durin42, #hg-reviewers
Cc: mharbison72, martinvonz, sluongng, tom.prince, sheehan, rom1dep, JordiGH, hollisb, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list