[PATCH 1 of 5 STABLE] setup-rust: remove the legacy 'direct-ffi' variant

[Yuya Nishihara]

On Sun, 8 Mar 2020 11:29:22 +0100, Pierre-Yves David wrote:
> On 3/8/20 6:42 AM, Yuya Nishihara wrote:
> > On Fri, 06 Mar 2020 17:25:21 +0100, Pierre-Yves David wrote:
> >> # HG changeset patch
> >> # User Pierre-Yves David <pierre-yves.david at octobus.net>
> >> # Date 1583509786 -3600
> >> #      Fri Mar 06 16:49:46 2020 +0100
> >> # Branch stable
> >> # Node ID 8a8b350871ac41bd33be78b200853275a6a235a2
> >> # Parent  b24721e7c5ee90c31d12462109c75b0389a9df84
> >> # EXP-Topic rust-test-option
> >> # Available At https://dev.heptapod.net/octobus/mercurial-devel/
> >> #              hg pull https://dev.heptapod.net/octobus/mercurial-devel/ -r 8a8b350871ac
> >> setup-rust: remove the legacy 'direct-ffi' variant
> > 
> > Seems not simple and important for stable branch.
> 
> The motivation to put it on stable was to get the --rust/--no-rust flag 
> for setup.py and run-test.py on stable (to make testing rust on stable 
> simpler).
> 
> If you want to take this on default, I have no objection. (It probably 
> apply cleanly, but I can rebase if needed).

I'll leave this series to someone else since I'm okay with the current
testability of the Rust code.

> >> -extern "C" {
> >> -    fn HgRevlogIndex_GetParents(
> >> -        op: IndexPtr,
> >> -        rev: c_int,
> >> -        parents: *mut [c_int; 2],
> >> -    ) -> c_int;
> >> -}
> > 
> > Maybe HgRevlogIndex_GetParents() can be turned into a static function.
> 
> I am removing this rust code. What do you mean for me to change?

Add "static" to HgRevlogIndex_GetParents() of mercurial/cext/revlog.c,
and remove related declarations from the header file.