D8282: tests: consistently put #testcases at beginning of file

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Mar 13 16:35:08 UTC 2020


martinvonz added a comment.


  In D8282#123665 <https://phab.mercurial-scm.org/D8282#123665>, @marmoute wrote:
  
  > That's a good point, doing it for `#require` too would be more consistent.
  > I would make a difference between test that do not make too much of an effort to have a title + early documentation and the one who actually make effort to have a formal format for their title and documentation (the one with `=====\ntitle\n=====` or `title\n=====`).
  > I would be fine with having the requires/testcases right after the title when it make senses. I think there are some instance where the variants are formally documented, and the `#testcase` block is part of that. It might make sense to keep them at that location.
  
  I'll leave this patch as is and leave the moving of comments above `#testcase` and `#requires` for you to do in a follow-up (if you care enough about it; I still prefer having the all these `#` statements at the top).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8282/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8282

To: martinvonz, durin42, #hg-reviewers, marmoute, mharbison72
Cc: mharbison72, marmoute, mercurial-devel


More information about the Mercurial-devel mailing list