D8287: fix: add a -s option to format a revision and its descendants

[mharbison72 (Matt Harbison)]

mharbison72 added a comment.


  Thanks for this!

INLINE COMMENTS

> fix.py:221
> +    [],
> +    _(b'fix descendants of these revisions'),
> +    _(b'REV'),

nit: is `descendants` usually self referential?  (The revset is, but IDK if that's what a casual reader would expect here.)  The same option for rebase says:

  rebase the specified changeset and descendants

> fix.py:412-413
> +    elif opts[b'source']:
> +        source_revs = scmutil.revrange(repo, opts[b'source'])
> +        revs = set(repo.revs(b'%ld::', source_revs))
> +        if wdirrev in source_revs:

Any idea why rebase seems to convert the `source` arg to a list before passing to `revrange()`, and also does `repo.revs(b'(%ld)::', src) or src`?  IDK if it's trying to handle something that should be handled here for consistent behavior.

https://www.mercurial-scm.org/repo/hg/file/tip/hgext/rebase.py#l1264

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8287/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8287

To: martinvonz, #hg-reviewers
Cc: mharbison72, hooper, mercurial-devel