D8338: hook: move stdio redirection to context manager

[indygreg (Gregory Szorc)]

indygreg added a comment.


  This commit isn't strictly required. I performed this refactoring anticipating needing to add `sys.std*` fixups as part of this function. But it turns out that the SSH protocol server handles I/O redirection via a different mechanism. There actually appear to be redundant mechanisms for intercepting stdio as part of the wire protocol. This is potentially an area that we could clean up. But I'm not inclined to do so at this time.
  
  Anyway, I feel the cleanup here improves readability, so I sent it along.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8338/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8338

To: indygreg, #hg-reviewers
Cc: mercurial-devel