D8314: phabricator: add an option to fold several commits into one review (issue6244)

[mharbison72 (Matt Harbison)]

mharbison72 added inline comments.
mharbison72 marked 2 inline comments as done.

INLINE COMMENTS

> Alphare wrote in phabricator.py:1424
> Not sure I understand `(None, None, None)[2]`

Good catch.  The subscript should be outside.

> Alphare wrote in test-phabricator.t:644
> I think we should have a test for `split` as well

I'll add in the test I have locally for splitting on the end, based on your last review.

Does it look good enough otherwise to run the tests against the upstream phab server?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8314/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8314

To: mharbison72, #hg-reviewers, Alphare
Cc: Alphare, Kwan, mercurial-devel