[PATCH 1 of 6] log: remove stale comment about order of user revset
Yuya Nishihara
yuya at tcha.org
Fri Sep 18 11:06:21 UTC 2020
# HG changeset patch
# User Yuya Nishihara <yuya at tcha.org>
# Date 1599894670 -32400
# Sat Sep 12 16:11:10 2020 +0900
# Node ID 5029cecce6ad76a194ad5478ac3fda614f3d32d6
# Parent c7fe0dfb53122bb72ff7e1fab75f2eec28b1883c
log: remove stale comment about order of user revset
_makerevset() no longer depends on the computed revs since ea3320015d54 "log:
remove dead code to follow descendants if ascending revisions specified."
diff --git a/mercurial/logcmdutil.py b/mercurial/logcmdutil.py
--- a/mercurial/logcmdutil.py
+++ b/mercurial/logcmdutil.py
@@ -898,14 +898,13 @@ def getrevs(repo, pats, opts):
expr = _makerevset(repo, match, pats, slowpath, opts)
if opts.get(b'graph'):
- # User-specified revs might be unsorted, but don't sort before
- # _makerevset because it might depend on the order of revs
if repo.ui.configbool(b'experimental', b'log.topo'):
if not revs.istopo():
revs = dagop.toposort(revs, repo.changelog.parentrevs)
# TODO: try to iterate the set lazily
revs = revset.baseset(list(revs), istopo=True)
elif not (revs.isdescending() or revs.istopo()):
+ # User-specified revs might be unsorted
revs.sort(reverse=True)
if expr:
matcher = revset.match(None, expr)
More information about the Mercurial-devel
mailing list