D10505: mail: add a TODO about proper mbox locking
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Wed Apr 21 03:31:58 UTC 2021
mharbison72 created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
Per @nbjoerg in IRC, the mbox isn't locked correctly.
REPOSITORY
rHG Mercurial
BRANCH
stable
REVISION DETAIL
https://phab.mercurial-scm.org/D10505
AFFECTED FILES
mercurial/mail.py
CHANGE DETAILS
diff --git a/mercurial/mail.py b/mercurial/mail.py
--- a/mercurial/mail.py
+++ b/mercurial/mail.py
@@ -220,6 +220,7 @@
def _mbox(mbox, sender, recipients, msg):
'''write mails to mbox'''
+ # TODO: use python mbox library for proper locking
with open(mbox, b'ab+') as fp:
# Should be time.asctime(), but Windows prints 2-characters day
# of month instead of one. Make them print the same thing.
To: mharbison72, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
More information about the Mercurial-devel
mailing list