D9984: softstrip: move _bookmarkmovements() call to where it's needed
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu Feb 11 22:37:18 UTC 2021
martinvonz created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
The call to `_bookmarkmovements()` is unrelated to the backup, so
let's move it after.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D9984
AFFECTED FILES
mercurial/repair.py
CHANGE DETAILS
diff --git a/mercurial/repair.py b/mercurial/repair.py
--- a/mercurial/repair.py
+++ b/mercurial/repair.py
@@ -308,11 +308,11 @@
if not tostrip:
return None
- newbmtarget, updatebm = _bookmarkmovements(repo, tostrip)
if backup:
node = tostrip[0]
backupfile = _createstripbackup(repo, tostrip, node, topic)
+ newbmtarget, updatebm = _bookmarkmovements(repo, tostrip)
with repo.transaction(b'strip') as tr:
phases.retractboundary(repo, tr, phases.archived, tostrip)
bmchanges = [(m, repo[newbmtarget].node()) for m in updatebm]
To: martinvonz, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
More information about the Mercurial-devel
mailing list