[Bug 6490] New: hgweb error on /archive/ without node

[mercurial-bugs at mercurial-scm.org]

https://bz.mercurial-scm.org/show_bug.cgi?id=6490

            Bug ID: 6490
           Summary: hgweb error on /archive/ without node
           Product: Mercurial
           Version: default branch
          Hardware: PC
                OS: Linux
            Status: UNCONFIRMED
          Severity: bug
          Priority: normal
         Component: hgweb
          Assignee: bugzilla at mercurial-scm.org
          Reporter: zash at zash.se
                CC: mercurial-devel at mercurial-scm.org
    Python Version: 3.7

Found this in logs while looking for errors:

[2021-02-21 05:26:03 +0000] [19488] [ERROR] Error handling request
/prosody-modules/archive/
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/gunicorn/workers/sync.py", line 135, in
handle
    self.handle_request(listener, req, client, addr)
  File "/usr/lib/python3/dist-packages/gunicorn/workers/sync.py", line 181, in
handle_request
    for item in respiter:
  File "/usr/lib/python3/dist-packages/mercurial/hgweb/hgwebdir_mod.py", line
381, in run_wsgi
    for r in self._runwsgi(req, res):
  File "/usr/lib/python3/dist-packages/mercurial/hgweb/hgweb_mod.py", line 326,
in run_wsgi
    for r in self._runwsgi(req, res, repo):
  File "/usr/lib/python3/dist-packages/mercurial/hgweb/hgweb_mod.py", line 398,
in _runwsgi
    fn = req.qsparams[b'node']
  File "/usr/lib/python3/dist-packages/mercurial/hgweb/request.py", line 35, in
__getitem__
    return self._items[key][-1]
KeyError: b'node'

Appears to happen if hgweb is hit with /archive/ (no node/rev given).

Reproduced on current tip = c82d6363bc9e by
./hg serve
curl http://localhost:8080/archive/

(in parallell)

-- 
You are receiving this mail because:
You are on the CC list for the bug.