D11073: windows: make sure we fully read and cleany close the connection
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Sat Jul 10 17:48:54 UTC 2021
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
Maybe this will prevent server on Windows to sometimes complains about the
client closing the connection too soon. So we make sure we read everything and
we officially close the connection.
Hopefully Windows will be happier and the test will stop being flaky.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D11073
AFFECTED FILES
tests/get-with-headers.py
CHANGE DETAILS
diff --git a/tests/get-with-headers.py b/tests/get-with-headers.py
--- a/tests/get-with-headers.py
+++ b/tests/get-with-headers.py
@@ -84,7 +84,11 @@
b"%s: %s\n"
% (h.encode('ascii'), response.getheader(h).encode('ascii'))
)
- if not headeronly:
+ if headeronly:
+ # still read the body to prevent windows to be unhappy about that
+ # (this might some flakyness in test-hgweb-filelog.t on Windows)
+ data = response.read()
+ else:
stdout.write(b'\n')
data = response.read()
@@ -112,6 +116,9 @@
if twice and response.getheader('ETag', None):
tag = response.getheader('ETag')
+ # further try to please the windows-flakyness deity
+ conn.close()
+
return response.status
To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
More information about the Mercurial-devel
mailing list