D11154: largefile: respect the `normal` signature
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Mon Jul 19 10:44:10 UTC 2021
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
The `parentfiledata` parameter was missing, we throw it away because I am not sure what to do with it in the largefile case.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D11154
AFFECTED FILES
hgext/largefiles/lfutil.py
CHANGE DETAILS
diff --git a/hgext/largefiles/lfutil.py b/hgext/largefiles/lfutil.py
--- a/hgext/largefiles/lfutil.py
+++ b/hgext/largefiles/lfutil.py
@@ -168,7 +168,9 @@
def set_untracked(self, f):
return super(largefilesdirstate, self).set_untracked(unixpath(f))
- def normal(self, f):
+ def normal(self, f, parentfiledata=None):
+ # not sure if we should pass the `parentfiledata` down or throw it
+ # away. So throwing it away to stay on the safe side.
return super(largefilesdirstate, self).normal(unixpath(f))
def remove(self, f):
To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
More information about the Mercurial-devel
mailing list