D11225: dummyssh: make sure we don't inherit files descriptor to the children
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Wed Jul 28 14:58:02 UTC 2021
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
This is one of the difference between python2 and python3 and could have been a
reason why test hang with python2 + chg. This does not seems to help the
hanging issue at allâ¦
However, now that this is written lets reduce the difference between python2
and python3.
REPOSITORY
rHG Mercurial
BRANCH
stable
REVISION DETAIL
https://phab.mercurial-scm.org/D11225
AFFECTED FILES
tests/dummyssh
CHANGE DETAILS
diff --git a/tests/dummyssh b/tests/dummyssh
--- a/tests/dummyssh
+++ b/tests/dummyssh
@@ -31,5 +31,5 @@
hgcmd = shlex.join(cmds)
# shlex generate windows incompatible string...
hgcmd = hgcmd.replace("'", '"')
-r = subprocess.call(hgcmd, shell=True)
+r = subprocess.call(hgcmd, shell=True, close_fds=True)
sys.exit(bool(r))
To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
More information about the Mercurial-devel
mailing list