D11226: run-tests: do not inherit file descriptor when running a command
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Wed Jul 28 14:58:34 UTC 2021
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
This is one of the difference between python2 and python3 and could have been a
reason why test hang with python2 + chg. This does not seems to help the
hanging issue at allâ¦
However, now that this is written lets reduce the difference between python2
and python3.
REPOSITORY
rHG Mercurial
BRANCH
stable
REVISION DETAIL
https://phab.mercurial-scm.org/D11226
AFFECTED FILES
tests/run-tests.py
CHANGE DETAILS
diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -1587,6 +1587,7 @@
proc = subprocess.Popen(
_bytes2sys(cmd),
shell=True,
+ close_fds=closefds,
cwd=_bytes2sys(self._testtmp),
env=env,
)
To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
More information about the Mercurial-devel
mailing list