D12157: scmutil: obsrevs is already a frozenset
av6 (Anton Shestakov)
phabricator at mercurial-scm.org
Wed Feb 9 15:44:46 UTC 2022
av6 created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D12157
AFFECTED FILES
mercurial/scmutil.py
CHANGE DETAILS
diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
--- a/mercurial/scmutil.py
+++ b/mercurial/scmutil.py
@@ -366,9 +366,7 @@
obsrevs = obsolete.getrevs(repo, b'obsolete')
if not cl.filteredrevs and not obsrevs:
return None
- # TODO: obsrevs should be a frozenset, but right now obsolete.getrevs()
- # may return a set, which is not a hashable type.
- key = (maxrev, hash(cl.filteredrevs), hash(frozenset(obsrevs)))
+ key = (maxrev, hash(cl.filteredrevs), hash(obsrevs))
else:
if not cl.filteredrevs:
return None
To: av6, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
More information about the Mercurial-devel
mailing list