D12293: config: remove conditional asserts
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Wed Mar 2 23:30:39 UTC 2022
indygreg created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
We always run on Python 3 now.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D12293
AFFECTED FILES
mercurial/config.py
CHANGE DETAILS
diff --git a/mercurial/config.py b/mercurial/config.py
--- a/mercurial/config.py
+++ b/mercurial/config.py
@@ -114,16 +114,15 @@
return [(k, v[0]) for (k, v) in items]
def set(self, section, item, value, source=b""):
- if pycompat.ispy3:
- assert not isinstance(
- section, str
- ), b'config section may not be unicode strings on Python 3'
- assert not isinstance(
- item, str
- ), b'config item may not be unicode strings on Python 3'
- assert not isinstance(
- value, str
- ), b'config values may not be unicode strings on Python 3'
+ assert not isinstance(
+ section, str
+ ), b'config section may not be unicode strings on Python 3'
+ assert not isinstance(
+ item, str
+ ), b'config item may not be unicode strings on Python 3'
+ assert not isinstance(
+ value, str
+ ), b'config values may not be unicode strings on Python 3'
if section not in self:
self._data[section] = util.cowsortdict()
else:
To: indygreg, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
More information about the Mercurial-devel
mailing list