D12341: py3: replace pycompat.itervalues(x) with x.values()
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Mar 4 03:34:36 UTC 2022
indygreg created this revision.
Herald added a reviewer: martinvonz.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
pycompat.itervalues(x) just calls x.values(). So this is equivalent.
The rewrite was perfomed via an automated search and replace.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D12341
AFFECTED FILES
contrib/synthrepo.py
hgext/journal.py
hgext/rebase.py
hgext/remotefilelog/connectionpool.py
hgext/remotefilelog/debugcommands.py
hgext/remotefilelog/repack.py
hgext/transplant.py
mercurial/branchmap.py
mercurial/exchange.py
mercurial/localrepo.py
mercurial/mergestate.py
mercurial/patch.py
mercurial/statprof.py
mercurial/ui.py
tests/test-pathencode.py
CHANGE DETAILS
diff --git a/tests/test-pathencode.py b/tests/test-pathencode.py
--- a/tests/test-pathencode.py
+++ b/tests/test-pathencode.py
@@ -66,7 +66,7 @@
counts[c] += 1
for c in '\r/\n':
counts.pop(c, None)
- t = sum(pycompat.itervalues(counts)) / 100.0
+ t = sum(counts.values()) / 100.0
fp.write('probtable = (')
for i, (k, v) in enumerate(
sorted(counts.items(), key=lambda x: x[1], reverse=True)
diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -2117,9 +2117,7 @@
"""
if not self._loggers:
return
- activeloggers = [
- l for l in pycompat.itervalues(self._loggers) if l.tracked(event)
- ]
+ activeloggers = [l for l in self._loggers.values() if l.tracked(event)]
if not activeloggers:
return
msg = msgfmt % msgargs
diff --git a/mercurial/statprof.py b/mercurial/statprof.py
--- a/mercurial/statprof.py
+++ b/mercurial/statprof.py
@@ -474,7 +474,7 @@
if i == 0:
sitestat.addself()
- return [s for s in pycompat.itervalues(stats)]
+ return [s for s in stats.values()]
class DisplayFormats:
@@ -745,9 +745,7 @@
def _write(node, depth, multiple_siblings):
site = node.site
visiblechildren = [
- c
- for c in pycompat.itervalues(node.children)
- if c.count >= (limit * root.count)
+ c for c in node.children.values() if c.count >= (limit * root.count)
]
if site:
indent = depth * 2 - 1
@@ -783,9 +781,7 @@
)
finalstring = liststring + codestring
- childrensamples = sum(
- [c.count for c in pycompat.itervalues(node.children)]
- )
+ childrensamples = sum([c.count for c in node.children.values()])
# Make frames that performed more than 10% of the operation red
if node.count - childrensamples > (0.1 * root.count):
finalstring = b'\033[91m' + finalstring + b'\033[0m'
diff --git a/mercurial/patch.py b/mercurial/patch.py
--- a/mercurial/patch.py
+++ b/mercurial/patch.py
@@ -1342,11 +1342,7 @@
fixoffset += chunk.removed - chunk.added
return (
sum(
- [
- h
- for h in pycompat.itervalues(applied)
- if h[0].special() or len(h) > 1
- ],
+ [h for h in applied.values() if h[0].special() or len(h) > 1],
[],
),
{},
diff --git a/mercurial/mergestate.py b/mercurial/mergestate.py
--- a/mercurial/mergestate.py
+++ b/mercurial/mergestate.py
@@ -13,7 +13,6 @@
from . import (
error,
filemerge,
- pycompat,
util,
)
from .utils import hashutil
@@ -467,7 +466,7 @@
"""return counts for updated, merged and removed files in this
session"""
updated, merged, removed = 0, 0, 0
- for r, action in pycompat.itervalues(self._results):
+ for r, action in self._results.values():
if r is None:
updated += 1
elif r == 0:
diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -2139,7 +2139,7 @@
nodetagscache = {}
for t, n in self._tagscache.tags.items():
nodetagscache.setdefault(n, []).append(t)
- for tags in pycompat.itervalues(nodetagscache):
+ for tags in nodetagscache.values():
tags.sort()
self._tagscache.nodetagscache = nodetagscache
return self._tagscache.nodetagscache.get(node, [])
diff --git a/mercurial/exchange.py b/mercurial/exchange.py
--- a/mercurial/exchange.py
+++ b/mercurial/exchange.py
@@ -854,7 +854,7 @@
checks = {p: [] for p in phases.allphases}
checks[phases.public].extend(pushop.remotephases.publicheads)
checks[phases.draft].extend(pushop.remotephases.draftroots)
- if any(pycompat.itervalues(checks)):
+ if any(checks.values()):
for phase in checks:
checks[phase].sort()
checkdata = phases.binaryencode(checks)
diff --git a/mercurial/branchmap.py b/mercurial/branchmap.py
--- a/mercurial/branchmap.py
+++ b/mercurial/branchmap.py
@@ -119,7 +119,7 @@
clbranchinfo = cl.branchinfo
rbheads = []
closed = set()
- for bheads in pycompat.itervalues(remotebranchmap):
+ for bheads in remotebranchmap.values():
rbheads += bheads
for h in bheads:
r = clrev(h)
@@ -406,7 +406,7 @@
def iterheads(self):
"""returns all the heads"""
self._verifyall()
- return pycompat.itervalues(self._entries)
+ return self._entries.values()
def copy(self):
"""return an deep copy of the branchcache object"""
diff --git a/hgext/transplant.py b/hgext/transplant.py
--- a/hgext/transplant.py
+++ b/hgext/transplant.py
@@ -106,7 +106,7 @@
if not os.path.isdir(self.path):
os.mkdir(self.path)
fp = self.opener(self.transplantfile, b'w')
- for list in pycompat.itervalues(self.transplants):
+ for list in self.transplants.values():
for t in list:
l, r = map(hex, (t.lnode, t.rnode))
fp.write(l + b':' + r + b'\n')
diff --git a/hgext/remotefilelog/repack.py b/hgext/remotefilelog/repack.py
--- a/hgext/remotefilelog/repack.py
+++ b/hgext/remotefilelog/repack.py
@@ -594,7 +594,7 @@
maxchainlen = ui.configint(b'packs', b'maxchainlen', 1000)
byfile = {}
- for entry in pycompat.itervalues(ledger.entries):
+ for entry in ledger.entries.values():
if entry.datasource:
byfile.setdefault(entry.filename, {})[entry.node] = entry
@@ -749,7 +749,7 @@
ui = self.repo.ui
byfile = {}
- for entry in pycompat.itervalues(ledger.entries):
+ for entry in ledger.entries.values():
if entry.historysource:
byfile.setdefault(entry.filename, {})[entry.node] = entry
diff --git a/hgext/remotefilelog/debugcommands.py b/hgext/remotefilelog/debugcommands.py
--- a/hgext/remotefilelog/debugcommands.py
+++ b/hgext/remotefilelog/debugcommands.py
@@ -210,7 +210,7 @@
continue
filepath = os.path.join(root, file)
size, firstnode, mapping = parsefileblob(filepath, decompress)
- for p1, p2, linknode, copyfrom in pycompat.itervalues(mapping):
+ for p1, p2, linknode, copyfrom in mapping.values():
if linknode == sha1nodeconstants.nullid:
actualpath = os.path.relpath(root, path)
key = fileserverclient.getcachekey(
diff --git a/hgext/remotefilelog/connectionpool.py b/hgext/remotefilelog/connectionpool.py
--- a/hgext/remotefilelog/connectionpool.py
+++ b/hgext/remotefilelog/connectionpool.py
@@ -8,7 +8,6 @@
from mercurial import (
hg,
- pycompat,
sshpeer,
util,
)
@@ -60,7 +59,7 @@
return conn
def close(self):
- for pathpool in pycompat.itervalues(self._pool):
+ for pathpool in self._pool.values():
for conn in pathpool:
conn.close()
del pathpool[:]
diff --git a/hgext/rebase.py b/hgext/rebase.py
--- a/hgext/rebase.py
+++ b/hgext/rebase.py
@@ -2257,7 +2257,7 @@
msg = _(b'rebase: (use "hg rebase --abort" to clear broken state)\n')
ui.write(msg)
return
- numrebased = len([i for i in pycompat.itervalues(state) if i >= 0])
+ numrebased = len([i for i in state.values() if i >= 0])
# i18n: column positioning for "hg summary"
ui.write(
_(b'rebase: %s, %s (rebase --continue)\n')
diff --git a/hgext/journal.py b/hgext/journal.py
--- a/hgext/journal.py
+++ b/hgext/journal.py
@@ -166,7 +166,7 @@
pass
while iterable_map:
- value, key, it = order(pycompat.itervalues(iterable_map))
+ value, key, it = order(iterable_map.values())
yield value
try:
iterable_map[key][0] = next(it)
diff --git a/contrib/synthrepo.py b/contrib/synthrepo.py
--- a/contrib/synthrepo.py
+++ b/contrib/synthrepo.py
@@ -212,7 +212,7 @@
for filename, mar, lineadd, lineremove, isbin in parsegitdiff(diff):
if isbin:
continue
- added = sum(pycompat.itervalues(lineadd), 0)
+ added = sum(lineadd.values(), 0)
if mar == 'm':
if added and lineremove:
lineschanged[
To: indygreg, martinvonz, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
More information about the Mercurial-devel
mailing list