D12423: tests: stop excluding the pycompat module from pyflakes
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Wed Mar 30 05:46:11 UTC 2022
mharbison72 created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
I assume this was skipped because of all of the py2 stuff causing a lot of spew.
The "unused" imports are left in place in case any 3rd party stuff is using it.
I don't care about most of it, but TortoiseHg uses `io` and `queue`, so
minimally I'd like to keep those.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D12423
AFFECTED FILES
tests/test-check-pyflakes.t
CHANGE DETAILS
diff --git a/tests/test-check-pyflakes.t b/tests/test-check-pyflakes.t
--- a/tests/test-check-pyflakes.t
+++ b/tests/test-check-pyflakes.t
@@ -15,11 +15,19 @@
$ testrepohg locate 'set:**.py or grep("^#!.*python")' \
> -X hgext/fsmonitor/pywatchman \
- > -X mercurial/pycompat.py -X contrib/python-zstandard \
+ > -X contrib/python-zstandard \
> -X mercurial/thirdparty \
> 2>/dev/null \
> | xargs "$PYTHON" -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
contrib/perf.py:*:* undefined name 'xrange' (glob) (?)
mercurial/hgweb/server.py:*:* undefined name 'reload' (glob) (?)
+ mercurial/pycompat.py:*:* 'codecs' imported but unused (glob)
+ mercurial/pycompat.py:*:* 'concurrent.futures' imported but unused (glob)
+ mercurial/pycompat.py:*:* 'http.client as httplib' imported but unused (glob)
+ mercurial/pycompat.py:*:* 'http.cookiejar as cookielib' imported but unused (glob)
+ mercurial/pycompat.py:*:* 'io' imported but unused (glob)
+ mercurial/pycompat.py:*:* 'queue' imported but unused (glob)
+ mercurial/pycompat.py:*:* 'socketserver' imported but unused (glob)
+ mercurial/pycompat.py:*:* 'xmlrpc.client as xmlrpclib' imported but unused (glob)
mercurial/util.py:*:* 'pickle' imported but unused (glob)
To: mharbison72, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
More information about the Mercurial-devel
mailing list