[Bug 6705] New: Py3 MSIs are not removing old py2 files on upgrade

[mercurial-bugs at mercurial-scm.org]

https://bz.mercurial-scm.org/show_bug.cgi?id=6705

            Bug ID: 6705
           Summary: Py3 MSIs are not removing old py2 files on upgrade
           Product: Mercurial
           Version: 6.1.2
          Hardware: PC
                OS: Windows
            Status: UNCONFIRMED
          Severity: bug
          Priority: wish
         Component: packaging
          Assignee: bugzilla at mercurial-scm.org
          Reporter: matt_harbison at yahoo.com
                CC: durin42 at gmail.com, gregory.szorc at gmail.com,
                    mercurial-devel at mercurial-scm.org
    Python Version: ---

I installed the official py2 build of 6.1.1 x64 on Windows 2019, and then
installed the official py3 build of 6.1.2 x64 over the top of it.  I'd expect
it to cleanup the old install and replace it with the new one, but it left
python27.dll (and maybe other things) behind.  It also added a second entry to
the Add/Remove programs list.

I haven't noticed this issue with the thg installers up to this point, but now
that I've ported the packaging from hg there for py3 builds, I'm seeing similar
issues sometimes.  No idea what the issue is (though the current thg issue
might be generating multiple MSIs with the same version number for testing). 
The validation feature in Orca complains about lots of stuff in the py2 MSI
(mostly around the VCRT merge modules), but the only things it flags in py3 are
these (which don't seem relevant):

ICE40   WARNING REINSTALLMODE is defined in the Property table. This may cause
difficulties.
ICE61   WARNING This product should remove only older versions of itself. No
Maximum version was detected for the current product.
(INSTALLEDMERCURIALPRODUCTS)

-- 
You are receiving this mail because:
You are on the CC list for the bug.