[Updated] D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Wed Apr 22 16:23:00 UTC 2020


Herald added a subscriber: mercurial-patches.
This revision now requires changes to proceed.
marmoute added a comment.
marmoute requested changes to this revision.


  The code looks good, but the message is a bit obscure, can you try finding something clearer for the end-users ?

INLINE COMMENTS

> phabricator.py:1324
> +        )
> +
>      fold = opts.get(b'fold')

I would be a bit more explicit. Maybe something like:

`cannot phasend revisions group with multiple heads: %list-of-all-heads%`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8454/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8454

To: mharbison72, #hg-reviewers, marmoute
Cc: mercurial-patches, marmoute, Kwan, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200422/34667a02/attachment.html>


More information about the Mercurial-patches mailing list