[Commented On] D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range

[marmoute (Pierre-Yves David)]

marmoute added inline comments.

INLINE COMMENTS

> mharbison72 wrote in phabricator.py:1324
> > I would be a bit more explicit. Maybe something like:
> > `cannot phasend revisions group with multiple heads: %list-of-all-heads%`
> 
> That message is less correct though, because it also doesn't want multiple roots either.  I can't think of any other places where we talk about "linear" offhand, but doesn't that immediately paint a picture of the problem for even non-gurus?

Well, ther would be one message for head and one message for roots. It is a bit anoying to have to solve two errors one after the other in the most complicated case. However the benefit of having a simpler message seems better.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8454/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8454

To: mharbison72, #hg-reviewers, marmoute
Cc: mercurial-patches, marmoute, Kwan, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200424/cc48ecb2/attachment-0001.html>