[Commented On] D8244: copies: fix the changeset based algorithm regarding merge
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Wed Apr 22 18:07:24 UTC 2020
marmoute added a comment.
In D8244#126503 <https://phab.mercurial-scm.org/D8244#126503>, @martinvonz wrote:
> In D8244#126461 <https://phab.mercurial-scm.org/D8244#126461>, @marmoute wrote:
>
>> Gentle ping on this. This is still ready for review.
>
> I'm still a bit worried about the performance regression and I was hoping to get more information about that. Now is the beginning of the next cycle, so I guess it's a good time to queue this now and test it on Google users. I'll review this soon.
I started poking at the performance and [spoiler] and this will be fine :-) Do not hold your breath, because there is a long road between "prototype to get numbers" and "clean implementation". If you can queue this, I would appreciate building on a more solid ground.
For example, on the worst pypy case I have been playing with:
Before the fix: ! wall 1.765737 comb 1.760000 user 1.690000 sys 0.070000 (median of 6)
After the fix: ! wall 29.983194 comb 29.880000 user 29.780000 sys 0.100000 (median of 3)
With curent state of speedup: ! wall 2.135641 comb 2.140000 user 2.120000 sys 0.020000 (median of 5)
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8244/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8244
To: marmoute, #hg-reviewers
Cc: mercurial-patches, martinvonz, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200422/5ddd703c/attachment-0002.html>
More information about the Mercurial-patches
mailing list