[Updated] D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range

Fri Apr 24 20:38:06 UTC 2020

mharbison72 added inline comments.

INLINE COMMENTS

> marmoute wrote in phabricator.py:1324
> Well, ther would be one message for head and one message for roots. It is a bit anoying to have to solve two errors one after the other in the most complicated case. However the benefit of having a simpler message seems better.

It's not clear to me that the individual messages will nudge the user in the right direction (I'm guessing with a `1+3` submission that complains about '1' being an extra head that some people will just drop '1' entirely).  But I'm fine with it, with a mention of "linear" in the hint as a compromise.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8454/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8454

To: mharbison72, #hg-reviewers, marmoute
Cc: mercurial-patches, marmoute, Kwan, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200424/211f6915/attachment-0002.html>