[Commented On] D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Fri Apr 24 22:10:07 UTC 2020


marmoute added inline comments.

INLINE COMMENTS

> mharbison72 wrote in phabricator.py:1324
> It's not clear to me that the individual messages will nudge the user in the right direction (I'm guessing with a `1+3` submission that complains about '1' being an extra head that some people will just drop '1' entirely).  But I'm fine with it, with a mention of "linear" in the hint as a compromise.

I don't ahve a strong opinion on the actual message as long as it is simple to understand and easily actionable. Your idea to mention linear(ity) in the hint seems good.

We can also start with something descent and improve it with suggestion later.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8454/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8454

To: mharbison72, #hg-reviewers, marmoute
Cc: mercurial-patches, marmoute, Kwan, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200424/05c8db05/attachment-0002.html>


More information about the Mercurial-patches mailing list