[Commented On] D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291)

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Thu Apr 30 05:25:19 UTC 2020


mharbison72 added a comment.


  I'm not real familiar with how rebase works, and seems like it's pretty intricate code.  I'd also feel better if there were tests for the original commit referenced.  But it's very unlikely that I'll have any time before the weekend to look at this again, so I thought I'd send it out now.  Maybe it's narrow enough or maybe somebody can backfill the tests, and we can avoid a known data shredder in the next release.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8489/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8489

To: mharbison72, martinvonz, #hg-reviewers
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200430/60b2341e/attachment-0002.html>


More information about the Mercurial-patches mailing list