[Commented On] D8771: localrepo: only use BOOKMARKS_IN_STORE_REQUIRMENT is we have a store

[pulkit (Pulkit Goyal)]

pulkit added a comment.


  In D8771#132274 <https://phab.mercurial-scm.org/D8771#132274>, @martinvonz wrote:
  
  > The commit message was hard to read.
  >
  >> localrepo: only use BOOKMARKS_IN_STORE_REQUIRMENT is we have a store
  >
  > My suggestion: localrepo: only use 'bookmarksinstore' requirement if we have 'store'
  
  Thank you!
  
  >> This adds check that if we are using store and if we are not, we skip adding the
  >> BOOKMARKS_IN_STORE_REQUIREMENT.
  >
  > My suggestion: This adds a check that we are have the 'store' requirement and if we are not, we skip adding the 'bookmarksinstore'.
  
  Thank you!
  
  > Regarding the patch itself, when will it be useful? Is the point to detect cases where we have created such repos? Or to prevent the user from creating new repos? Why don't we update the read path to ignore 'bookmarksinstore' if 'store' is not enabled? Can we have a test case or two (just manually add 'bookmarksinstore' to `.hg/requires`)?
  
  We prevent user from creating new repos. Added a test for that.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8771/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8771

To: pulkit, #hg-reviewers
Cc: martinvonz, marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200801/edb728b8/attachment.html>