[Updated] D8845: templatespec: create a factory function for each type there is

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sun Aug 2 16:14:50 UTC 2020


This revision is now accepted and ready to land.
indygreg added inline comments.
indygreg accepted this revision.

INLINE COMMENTS

> martinvonz wrote in formatter.py:582
> Is `unspecified_templatespec()` better? Or maybe `plain_templatespec()`? It seems to result in a `plainformatter` getting used.

Naming is hard. I won't let this hold up review.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8845/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8845

To: martinvonz, #hg-reviewers, indygreg
Cc: indygreg, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200802/2be2cbde/attachment.html>


More information about the Mercurial-patches mailing list