[Updated] D8799: merge: return a mergeresult obj from manifestmerge(), calculateupdates() (API)

[indygreg (Gregory Szorc)]

This revision is now accepted and ready to land.
indygreg added inline comments.
indygreg accepted this revision.

INLINE COMMENTS

> merge.py:563
> +    @property
> +    def actions(self):
> +        return self._actions

I'm generally not a fan of having trivial `@property` wrappers for internal attributes like this, as I don't think it adds any value. Especially since there is code mutating the internal state, which is a bit janky.

But I'll approve this anyway. If the code remains unchanged after the completion of the series, my vote is to remove the `@property` wrappers and access attributes directly.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8799/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8799

To: pulkit, #hg-reviewers, indygreg
Cc: indygreg, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200802/d93e2b46/attachment.html>