[Accepted] D8861: hg-core: make parse_dirstate return references rather than update hashmaps

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Mon Aug 3 14:59:29 UTC 2020


Alphare added inline comments.
Alphare accepted this revision.

INLINE COMMENTS

> parsers.rs:34
> +        Ok((parents, entries, copies)) => {
> +            let mut dirstate_map: FastHashMap<HgPathBuf, DirstateEntry> =
> +                FastHashMap::default();

These should be a `collect()` instead of `default` + `extend`.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8861/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8861

To: acezar, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200803/6a42086c/attachment-0002.html>


More information about the Mercurial-patches mailing list