[Commented On] D8894: templater: make open_template() read from resources if in frozen binary

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu Aug 6 01:00:15 UTC 2020


indygreg added inline comments.

INLINE COMMENTS

> templater.py:1098
> +            )
> +        except (ModuleNotFoundError, FileNotFoundError):
> +            return None, None

`pyflakes` is complaining about undefined symbols on Python 2. I'm not sure how to best handle this though. I'll leave this queued for now because it doesn't seem to be harming tests otherwise. But it may have impact for non-PyOxidizer Windows `py2exe` builds.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8894/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8894

To: martinvonz, #hg-reviewers, indygreg
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200806/23bd573b/attachment-0002.html>


More information about the Mercurial-patches mailing list