[Updated] D8894: templater: make open_template() read from resources if in frozen binary

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Aug 6 05:11:39 UTC 2020


martinvonz added inline comments.

INLINE COMMENTS

> indygreg wrote in templater.py:1098
> `pyflakes` is complaining about undefined symbols on Python 2. I'm not sure how to best handle this though. I'll leave this queued for now because it doesn't seem to be harming tests otherwise. But it may have impact for non-PyOxidizer Windows `py2exe` builds.

Oops, sorry about that, I've only been running py3 tests lately. It's probably fine to simply catch the broader classes `ImportError` and `OSError`. I'll send a patch for that.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8894/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8894

To: martinvonz, #hg-reviewers, indygreg
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200806/80053390/attachment-0002.html>


More information about the Mercurial-patches mailing list