[Updated] D8633: share: introduce config option to store requires in .hg/store

[pulkit (Pulkit Goyal)]

pulkit added a comment.
pulkit marked 3 inline comments as done.
pulkit planned changes to this revision.


  In D8633#133117 <https://phab.mercurial-scm.org/D8633#133117>, @indygreg wrote:
  
  > I left a handful of comments.
  > Changing repo opening semantics and requirements handling is a bit scary.
  > I'm generally in favor of separating working directory requirements from non-working directory requirements so I think this patch is a step in the right direction. There are a few alternative implementations worth considering. (Although I'm unsure if they are superior.)
  >
  > 1. Write the new requirements file in the `.hg` directory as `.hg/store-requires` (or similar). Conceptually, we're talking about working directory and backend requirements. The "store" is just today's layout for storing backend data [which can be shared between working directories].
  > 2. Write a new requirements file for working directory specific requirements.
  
  Hi, thanks a lot for the detailed review. I think we can have `.hg/requires` as working directory specific and `.hg/store/requires` as store requirements.
  
  I have not yet implemented all the fixes you mentioned. Hence marking this as planned changes. However I have added some parents patches which should be good to review.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8633/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8633

To: pulkit, #hg-reviewers, durin42, marmoute
Cc: indygreg, marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200807/5f2f6349/attachment-0002.html>