[Commented On] D8887: mergeresult: add `files()` and use it

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sat Aug 8 16:51:19 UTC 2020


indygreg added a comment.


  FWIW I encountered the following test failure when running this series locally:
  
    --- /home/gps/src/hg-committed/tests/test-remotefilelog-prefetch.t
    +++ /home/gps/src/hg-committed/tests/test-remotefilelog-prefetch.t.err
    @@ -241,7 +241,6 @@
       ? files fetched over 1 fetches - (? misses, 0.00% hit ratio) over * (glob)
       abort: z2 at 109c3a557a73: not found in manifest! (?)
       $ find $CACHEDIR -type f | sort
    -  $TESTTMP/hgcache/master/11/f6ad8ec52a2984abaafd7c3b516503785c2072/ef95c5376f34698742fe34f315fd82136f8f68c0
       $TESTTMP/hgcache/master/39/5df8f7c51f007019cb30201c49e884b46b92fa/69a1b67522704ec122181c0890bd16e9d3e7516a
       $TESTTMP/hgcache/master/95/cb0bfd2977c761298d9624e4b4d4c72a39974a/076f5e2225b3ff0400b98c92aa6cdf403ee24cca
       $TESTTMP/hgcache/repos
  
  But the failure wasn't reproducible when running the test in isolation. It might be a race condition somewhere. Possibly due to `prefetch()` now taking a generator after this patch.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8887/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8887

To: pulkit, #hg-reviewers, indygreg
Cc: indygreg, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200808/5cf80b2e/attachment-0002.html>


More information about the Mercurial-patches mailing list