[Commented On] D8908: store: refactor space delimited list to proper tuple

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sat Aug 8 17:13:07 UTC 2020


indygreg added inline comments.

INLINE COMMENTS

> store.py:458
>      def copylist(self):
> -        return [b'requires'] + _data.split()
> +        return [b'requires'] + _data
>  

+    File "/home/gps/src/hg-committed/mercurial/store.py", line 458, in copylist
  +      return [b'requires'] + _data
  +  TypeError: can only concatenate list (not "tuple") to list

I think I'll just change `_data` to a `list` in-flight.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8908/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8908

To: pulkit, #hg-reviewers, indygreg
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200808/c1c1b469/attachment-0002.html>


More information about the Mercurial-patches mailing list