[Changed Subscribers] D8872: rhg: make output of `files` relative to the current directory and the root

[indygreg (Gregory Szorc)]

indygreg added inline comments.

INLINE COMMENTS

> files.rs:274
> +/// ```
> +pub fn relativize_path(path: &HgPath, cwd: impl AsRef<HgPath>) -> Cow<[u8]> {
> +    if cwd.as_ref().is_empty() {

It feels weird to me that this returns `[u8]` instead of an `HgPath[Buf]`. What's your justification for this?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8872/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8872

To: acezar, #hg-reviewers, Alphare
Cc: indygreg, Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200808/5eb52829/attachment-0002.html>