[Changed Subscribers] D8919: mergestate: use collections.defaultdict(dict) for _stateextras
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Tue Aug 11 01:06:28 UTC 2020
indygreg added inline comments.
INLINE COMMENTS
> mergestate.py:701
> del self._state[dfile]
> - self._stateextras.pop(dfile, None)
> + self._stateextras.pop(dfile)
> self._dirty = True
This changes behavior so `pop()` will raise `KeyError` on a missing key. Is this desired?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8919/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8919
To: pulkit, #hg-reviewers, marmoute
Cc: indygreg, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200811/0852500a/attachment-0002.html>
More information about the Mercurial-patches
mailing list