[Updated] D8919: mergestate: use collections.defaultdict(dict) for _stateextras

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Tue Aug 11 07:47:06 UTC 2020


pulkit added inline comments.

INLINE COMMENTS

> indygreg wrote in mergestate.py:701
> This changes behavior so `pop()` will raise `KeyError` on a missing key. Is this desired?

Nope. It's was my wrong understanding of `collections.defaultdict()`. Fixed it.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8919/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8919

To: pulkit, #hg-reviewers, marmoute
Cc: indygreg, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200811/4e9f50ea/attachment-0002.html>


More information about the Mercurial-patches mailing list