[Commented On] D8868: rhg: add a `Files` `Command` to prepare the `rhg files` subcommand

[Alphare (Raphaël Gomès)]

Alphare added inline comments.

INLINE COMMENTS

> indygreg wrote in files.rs:46
> I imagine this pattern could become quite common. We may want to introduce some type of _writer_ type that has `impl Drop` so we can do something like the following:
> 
>   {
>       let mut stdout = self.ui.stdout_writer();
>       stdout.write(b"...")?;
>   }

I can see that being useful, we'll see if that comes up a lot. The question of doing line-buffering as a config option is still up for debate, maybe that'll complicate the pattern you're proposing somewhat.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8868/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8868

To: acezar, #hg-reviewers, Alphare, indygreg
Cc: indygreg, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200812/e39211cd/attachment-0002.html>