[Commented On] D8872: rhg: make output of `files` relative to the current directory and the root

[Alphare (Raphaël Gomès)]

Alphare added inline comments.

INLINE COMMENTS

> indygreg wrote in files.rs:274
> It feels weird to me that this returns `[u8]` instead of an `HgPath[Buf]`. What's your justification for this?

An `HgPath[Buf]` is meant to be the canonical internal representation of a Mercurial path. There are a few places already where this "rule" is violated, but I am planning on refactoring them, and I can start by not adding a new instance of that issue.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8872/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8872

To: acezar, #hg-reviewers, Alphare
Cc: indygreg, Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200812/b22696f6/attachment-0002.html>