[Updated] D8937: rust: enable on macOS
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Fri Aug 21 08:24:50 UTC 2020
This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.
What do you mean by "mishandling removed files"? The fold map is there to give a mapping between the normalized (internal) representation of file paths and the actual ones on disk. As much as I hate the dirstate code, this is a useful part of the software that is triggered depending on your filesystem and paths used.
I don't have a machine running MacOS to run the tests on, all I know is that if the repo root is on a FS that is case-insensitive, the Rust code will not be run. Also, the PathAuditor failing is not a good sign.
I am currently rewriting some of the dirstate code, hopefully my experiment can make it upstream and improve the code, but I don't think "official" support for MacOS can come before we get a CI running all the tests and at least someone dogfooding it a little.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8937/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8937
To: danchr, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200821/201ad22b/attachment-0002.html>
More information about the Mercurial-patches
mailing list