[Updated] D8913: scmutil: introduce filterrequirements() to split reqs into wc and store ones

[indygreg (Gregory Szorc)]

This revision now requires changes to proceed.
indygreg added inline comments.
indygreg requested changes to this revision.

INLINE COMMENTS

> scmutil.py:1501
> +    if storereq:
> +        writerequires(repo.svfs, storereq)
>  

Since the presence or lack thereof of the `requires` file is important, I think we should change this to `if x is not None` so an empty file is written out if appropriate. This should happen, of course. But semantically it is the more correct behavior.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8913/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8913

To: pulkit, #hg-reviewers, indygreg
Cc: indygreg, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200825/dba058b6/attachment-0002.html>