[Updated] D8633: share: introduce config option to store requires in .hg/store

[pulkit (Pulkit Goyal)]

pulkit added a comment.


  In D8633#133939 <https://phab.mercurial-scm.org/D8633#133939>, @indygreg wrote:
  
  > I was going to push this but there's a test failure:
  >
  >   --- /home/gps/src/hg-committed/tests/test-remotefilelog-share.t
  >   +++ /home/gps/src/hg-committed/tests/test-remotefilelog-share.t#safe.err
  >   @@ -28,6 +28,7 @@
  >      $ hgcloneshallow ssh://user@dummy/master source --noupdate -q
  >   +  devel-warn: write with no lock: "requires" at: /home/gps/src/hg-committed/mercurial/scmutil.py:1505 (writerequires)
  >      $ hg share source dest
  >      updating working directory
  >      1 files updated, 0 files merged, 0 files removed, 0 files unresolved
  
  Oops, turns out shallow-cloning in remotefilelog does not acquire a lock. I added D8952 <https://phab.mercurial-scm.org/D8952> in start of series to acquire lock while writing requires in shallow-cloning in remotefilelog.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8633/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8633

To: pulkit, #hg-reviewers, durin42, marmoute, indygreg
Cc: indygreg, marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200826/01d1a55f/attachment-0002.html>